commit 903a8685c661ddde61335a08e126506120345abc Author: Nick Clemens Date: Thu Apr 18 11:17:33 2024 +0000 Bug 36473: (follow-up) Additionally warn the stringified exception Signed-off-by: Katrin Fischer commit 1b99de33f9e553f80507ef7da5e711b98e979e39 Author: Nick Clemens Date: Thu Apr 18 10:35:52 2024 +0000 Bug 36473: (follow-up) Add biblionumber to warning Signed-off-by: Katrin Fischer commit 0191500149433313aa73a6c43255a19d659acad0 Author: Nick Clemens Date: Thu Apr 18 10:33:40 2024 +0000 Bug 36473: (follow-up) Correct biblio to bibliographic Signed-off-by: Katrin Fischer commit 2973a4e81a2878b8d2654477b2556ad1b1fb4e46 Author: Marcel de Rooy Date: Thu Mar 21 14:17:35 2024 +0000 Bug 36386: Pass user and group to Net::Server This prevents the User/Group Not Defined warns in syslog. Test plan: Restart sip and check your syslog. KTD Test Plan: 1) Stop your SIP server 2) Run "perl C4/SIP/SIPServer.pm /etc/koha/sites/kohadev/koha-conf.xml" We need valid XML without any valid SIP settings to the output goes to the command line 3) Note the warnings 4) Apply this patch 5) Repeat step 2 6) No warnings! Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 644294e73bb17cc1527aaef5259de54106deb8cc Author: Matt Blenkinsop Date: Wed Apr 17 15:03:53 2024 +0000 Bug 36623: Remove localhost reference This patch removes a reference to localhost from a url within ERM Test plan: This is quite hard to test without sushi credentials and is quite an easy fix. Check the patch diff to verify that the localhost reference has now been removed from the url Signed-off-by: Katrin Fischer commit e90cba4e3819fd244e9397fec6c1bc0c4984690d Author: Jonathan Druart Date: Wed Apr 17 12:06:03 2024 +0200 Bug 30068: Remove table_settings_borrowers_table from circulation.tt The history is a mess, but here we init a JS variable that is never used. Test plan: git grep table_settings_borrowers_table should not return anything after this patch applied Signed-off-by: Caroline Cyr La Rose Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 1e9bdfb56c5c871a6d29ebc0a0e6d70267a209fe Author: Owen Leonard Date: Tue Apr 2 12:41:42 2024 +0000 Bug 36490: Correct tab-switching keyboard shortcut for header search forms This patch updates staff-global.js so that we correctly define the keyboard shortcuts for search header tabs following the switch to using the WRAPPER for tabs in Bug 35850. To test, apply the patch clear your browser cache if necessary. - Go to the staff interface. - Test each keyboard shortcut to confirm that the header search tabs activate correctly: - Check in: Alt-r - Renew: Alt-w - Search: Alt-q - Check out: Alt-u - Test that the keyboard shortcut takes you to the correct page if the header search form doesn't exist on the page, e.g. the Authorities home page. Signed-off-by: Andrew Fuerste Henry Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 154a2ea9ad5b6e911a504b8798f5ffe6df1c2297 Author: Tomás Cohen Arazi Date: Wed Mar 27 12:01:32 2024 +0000 Bug 36420: Allow Basic authentication using `cardnumber` This patch makes the API Basic authentication work with cardnumbers. The used `checkpw_internal` method already does the fallback check. To test: 1. Apply the unit tests patch 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/auth_basic.t => FAIL: Tests explode! [1] 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D [1] This highlights an underlying bug! Instead of getting 403, etc we get a 500. This is because of the internal fallback mechanism allowing the cardnumber+password combination, but then the Koha::Patron->find... not finding :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 5c3ad38157f483aeb4ff26048a838b3ba6ad34fc Author: Tomás Cohen Arazi Date: Wed Mar 27 12:00:48 2024 +0000 Bug 36420: Unit tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit fccbd327d9f93925917e7a4f478ab72c1d1f2363 Author: Lucas Gass Date: Mon Feb 26 15:59:29 2024 +0000 Bug 30987: Fix relationship fields for patron full and quick add forms To test: 1. APPLY PATACH and restart services. 2. Find the borrowerRelationship system preference. The description should no longer include the words "Leave empty to deactivate." 3. Populate the system preference with at least 1 choice. 4. Find a patron category with can_be_guarantee set to 'Yes'. 5. Quick add a patron of that type, making sure the relationship field shows in the Patron guarantor section. ( You have to +Add gaurantor before this field will show ) 6. The values in the dropdown should refelct the borrowerRelationship values. 7. With BorrowerMandatoryField make relationship mandatory. 8. Try step 5 again, this time the Relationship field should be mandatory. 9. Remove the field from BorrowerMandatoryField and add it to BorrowerUnwantedField. 10. Do step 5 again, the relationship field should not show on the quick add form. Signed-off-by: Myka Kennedy Stephens Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 82fe22ff26fdcc203d1a6f9c281bd56cfff08f70 Author: Brendan Lawlor Date: Wed Apr 17 20:57:34 2024 +0000 Bug 36630: Change Post to GET to fix CSRF error on item search batch operations buttons This patch changes the form that submits to batchMod.pl from the Item search results page. The form method does not need to be a POST. To recreate: 1. Do an item search 2. On the results page 'click Select visible rows' 3. Click 'Batch operations' and select 'Batch item modification' 4. See Programming error - op 'show' must start with 'cud-' for POST http://localhost:8081/intranet/tools/batchMod.pl (referer: http://localhost:8081/cgi-bin/koha/catalogue/itemsearch.pl) 5. Click 'Batch operations' and select 'Batch item deletion' 6. See the same error To test: 1. Apply patch and repeat steps to recreate the issue 2. See that the batchMod.pl page loads with no error. Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer commit 68f884d32fb1cfc2d629c117d0932cfa709dec37 Author: Janusz Kaczmarek Date: Thu Apr 11 12:36:25 2024 +0000 Bug 36577: (bug 34478 follow-up) marc21_linking_section.pl not working After applying "Bug 34478: op =~ ^cud- everywhere" the plugin marc21_linking_section.pl stopped working properly. Since the plugin does not perform a CUD operation, the GET request can be used, and so the use of CSRF token is not needed. The patch fixes also problems with result page numbers display. Test plan ========= 1. Configure a MARC bibliographic framework to use the plugin marc21_linking_section.pl (e.g. in 773 $t). 2. Start creating a new record and go to 773 $t. Activate the plugin to find the any record to become the host record (perform a search for any common word, like 'and'). 3. You will get no results. 4. Apply the patch, restart plack etc. 5. Repeat p. 2 - you should now see some results, possibly more than one page. You should be able to change page with Next/Previous arrows and also with the page numbers. BTW, QA people - maybe it would pay to remove the commented code present there since the very beginning (2012). Signed-off-by: Roman Dolny Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit a81c98e1ea39f4b04bb3eec2fde7c8c6f331e6a3 Author: Owen Leonard Date: Fri Apr 12 12:31:15 2024 +0000 Bug 36597: Fix deletion of circulation desks broken by CSRF Our CSRF work introduced a problem with deleting circulation desks: The "delete_confirm" does not need "cud-" because it's a GET operation leading to a POSTed deletion after the confirmation is submitted. To test, apply the patch and restart services. - Go to Administration -> Circulation desks. - If necessary, create a circulation desk. - Click the "Delete" button for you new desk. - You should be taken to a confirmation page which shows details of the desk you're deleting. - Confirming the deletion should result in deletion of the desk. Signed-off-by: Brendan Lawlor Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit e26fc0a3d5a83a7b22f0c3907a98d470b0e2443d Author: Brendan Lawlor Date: Fri Apr 12 15:29:37 2024 +0000 Bug 33832: Allow updating username without changing password on member-password.pl This patch updates the change password page on the staff interface to allow for changing the patron's username without changing the password. If the new password is an empty string we can skip setting the patron's password and sending the new password to the template. Test plan: 1. From a patron record tool bar click 'Change password' 2. Notice that if you try to change the user's name without also changing the password the page just reloads and nothing happens 3. Apply patch and restart_all 4. From the patron record click 'Change password' again 5. Set the user's new username and password eg. '1234Abc' and click 'Save' 6. Confirm that you can log in to the OPAC with the user 7. Return to the patron record and click 'Change password' again 8. This time change just the 'New username field' and click 'Save' 6. Notice that the username is updated 7. Confirm you can log into the OPAC with the new username and the original password '1234Abcd' 8. Make sure that the change password form still validates passwords for length and matching errors etc Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 7c71798b44c93be650bb5c5c682a4a24f83ba20d Author: Emily Lamancusa Date: Tue Feb 20 09:49:48 2024 -0500 Bug 35810: (QA follow-up) Add aria label for accessibility Signed-off-by: Emily Lamancusa Signed-off-by: Katrin Fischer commit 926e87de86496003915247bf6d50e4290fd3a1e4 Author: Thibaud Guillot Date: Mon Jan 15 11:19:51 2024 +0100 Bug 35810: Add back to top button on staff pages Test plan: 1) Apply this patch and rebuild css with 'yarn build' 2) For example, perform a search from catalogue 3) Scroll down to see the button appear and scroll up to see it disappear Note that it's works also on patron search etc.. Signed-off-by: Owen Leonard Signed-off-by: Pedro Amorim Signed-off-by: Emily Lamancusa Signed-off-by: Katrin Fischer commit 24fab500c402b2d91a51e29beaf72fdff918ad22 Author: Nick Clemens Date: Wed Nov 29 16:37:04 2023 +0000 Bug 35432: Expand comments to explain the priority of filling requests Signed-off-by: Phil Ringnalda Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 1bc658e0470322a2d45da3f27f5f32eb8891b8aa Author: Nick Clemens Date: Wed Nov 29 15:00:18 2023 +0000 Bug 35432: Remove PULL_BRANCHES and use ifs over unless PULL_BRANCHES and PULL_BRANCHES2 felt a little arbitrary, moved to using a last in the outer loop. Swapped 'next unless' for an if to more directly show when we are acting Signed-off-by: Phil Ringnalda Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 707b655b6249d56e69c0d95de434a6eef173bf03 Author: Nick Clemens Date: Wed Nov 29 14:50:41 2023 +0000 Bug 35432: Simplay HoldsQueuePrioritize branch check The code here is going to check items held the the pickup location for a request or from the least cost branch matching the patron's home library against the HoldsQueuePrioritizeBranch setting The loop is the same in both case, so lets simplify this a bit to make the intent more clear To test: 1 - prove -v t/db_dependent/HoldsQueue.t 2 - It should pass before and after this patch Signed-off-by: Phil Ringnalda Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 0297cb8c175818aa9081e1a8e9682af9ad68ae78 Author: Nick Clemens Date: Wed Nov 29 14:15:09 2023 +0000 Bug 35432: Add _can_item_fill_request subroutine There are a series of repeated checks throughout MapItemsToHoldRequests. This patch simply consolidates them into a single routine that can be called. To test: 1 - prove t/db_dependent/HoldsQueue.t 2 - Confirm it passes before and after this patch is applied Signed-off-by: Phil Ringnalda Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit c3ac21bffcb28ad538e4ba7f25c4503761122924 Author: Nick Clemens Date: Wed Nov 29 14:02:08 2023 +0000 Bug 35432: Add comments and POD Signed-off-by: Phil Ringnalda Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit a130290ccb1c96583b07a9e9ce81f6cafa47f794 Author: Nick Clemens Date: Fri Apr 12 07:36:52 2024 +0000 Bug 20388: (QA follow-up) Tidy Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer commit ec56284a26d73ca72de657f7a8880c99d46dd880 Author: Jonathan Druart Date: Tue Mar 19 16:00:04 2024 +0100 Bug 20388: Alert if the search field already exists Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Michaela Sieber Signed-off-by: David Schmidt Signed-off-by: Thomas Klausner Signed-off-by: David Schmidt Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer commit 748abf178425e281de6f0dd8d895ec9bc73a9ca1 Author: Jonathan Druart Date: Tue Mar 19 15:33:12 2024 +0100 Bug 20388: Add trash icon to the delete button Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Michaela Sieber Signed-off-by: David Schmidt Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer commit 79b06917f7ff905c77189ff017279d8fce998bab Author: Jonathan Druart Date: Tue Mar 19 15:28:30 2024 +0100 Bug 20388: Adjust code Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Michaela Sieber Signed-off-by: David Schmidt Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer commit 0607e6adfa2dec9e92312303bfa1f11273eda39d Author: Alex Arnaud Date: Wed Apr 7 13:20:53 2021 +0000 Bug 20388: Elasticsearch - Ability to add search fields from UI Test plan: - apply this patch, - check that SearchEngine system preference is set to Elasticsearch, - go to Admin > Search engine configuration, - on the search fields tab, fill a new line at the bottom of the table (name, label, type) - click on the "Add" button and save, - check that the new search field has been saved, - also test field deletions, - check that you can't delete already mapped fields. Signed-off-by: Nicolas Legrand Signed-off-by: Séverine QUEUNE Signed-off-by: Nick Clemens Signed-off-by: Björn Nylén Signed-off-by: Julian Maurice Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Michaela Sieber Signed-off-by: David Schmidt Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer commit 0e4677d3ef7f532e588fc016bc51b7bdb8a8e3f3 Author: Katrin Fischer Date: Tue Apr 16 15:21:00 2024 +0000 Bug 36343: DBRev 23.12.00.020 Signed-off-by: Katrin Fischer commit 4b5a02bd1d9c4dc14151578d5a950a282add424a Author: Martin Renvoize Date: Tue Apr 16 13:13:55 2024 +0100 Bug 36343: (QA follow-up) Add warning in DB update Signed-off-by: Katrin Fischer commit b6b6f06457c30959766bb62f834d5e66a039fe75 Author: Marcel de Rooy Date: Fri Apr 5 07:29:40 2024 +0000 Bug 36343: (QA follow-up) Adjust two other occurrences Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer commit 55fce66a3f141ec31016974ca163ed35c795595f Author: Martin Renvoize Date: Mon Mar 18 13:36:11 2024 +0000 Bug 36343: Add support for 'payload' to _after_biblio_action This patch adds support for the payload key into the _after_bilio_action plugin hook wrapper routine. This brings it more inline with how these 'action hooks' appear in Holds and circulation. Signed-off-by: Frédéric Demians Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer commit 056b56a3c3afd70166456d5a9e98371ddaa37e7b Author: Tomás Cohen Arazi Date: Mon Apr 15 06:57:49 2024 -0300 Bug 36593: Add missing koha_object(s)_class methods to LibraryHour.pm (bug 9796) Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 86f917e2bd92a8d8a9ad6286e9a3cc695d2e3e53 Author: Tomás Cohen Arazi Date: Mon Apr 15 06:56:53 2024 -0300 Bug 36593: Add 'time' column type support to TestBuilder This simple patch adds support for the 'time' column type. To test: 1. Run: $ ktd --shell k$ perl -Mt::lib::TestBuilder -e 'my $b = t::lib::TestBuilder->new; my $hour = $b->build_object({ class => "Koha::Library::Hours" });' => FAIL: It explodes as it doesn't know how to deal with the 'time' column type 2. Apply this patch and the follow-up 3. Run: k$ prove -MDDP -Mt::lib::TestBuilder -e 'my $b = t::lib::TestBuilder->new; my $h = $b->build_object({ class => "Koha::Library::Hours" }); p($h->unblessed);' => SUCCESS: It generates an hour! 4. Run: k$ prove t/db_dependent/TestBuilder.t => SUCCESS: It builds all the things! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 9c2510ea2ef1db46bf42cf948b6c599250d6dd9e Author: Janusz Kaczmarek Date: Sat Mar 11 11:45:32 2023 +0100 Bug 33205: (bug 28268 follow-up) Method call $row->authid inside quotes - produces meaningless warning Bug 28268, in Koha::MetadataRecord::Authority::get_all_authorities_iterator, introduced a warning: warn "Something went wrong reading record for authority $row->authid: $@\n"; But a method cannot be called from within quotes in Perl - extrapolation does not work for functions/methods. So, if something really goes wrong, this line of code produces a warning like: Something went wrong reading record for authority Koha::Schema::Result::AuthHeader=HASH(0x55cf7e0d0958)->authid: Empty String at /usr/share/perl5/MARC/File/XML.pm line 450. which is not very informative -- authid is missing. Test plan ========= Hard to reproduce. This problem occurs only in rare cases of some weird problem in stores authority data or if a auth record had been deleted after a ES reindex action has been initiated. But the problem in the code and the fix seem obvious. Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer commit cc834ba187b7d4a4b817d73f5c4be0eb0ebdaaf4 Author: Marcel de Rooy Date: Fri Apr 12 08:10:18 2024 +0000 Bug 36552: (QA follow-up) Add a theoretical check on $record Theoretically, it might be empty? Note the check too in the other script. Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer commit 34746f5706fb49377e5d610a9fe6e2c4792b9b26 Author: Marcel de Rooy Date: Fri Apr 12 08:07:40 2024 +0000 Bug 36552: (QA follow-up) Add POSIX module Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer commit dd8f9e1266f2b93b0d57f1f1289d49f61129391e Author: Janusz Kaczmarek Date: Thu Apr 27 01:04:48 2023 +0200 Bug 36552: Update record 'date entered on file' when duplicating a record The 'date entered on file' (MARC21: 008/0-5, UNIMARC: 100a/0=7) of a record created by duplication of an existing record should be set to the current date instead of having the value of the original record. Test plan ========= 1. Check the 'date entered on file' of an existing biblio / authotiry record (MARC21: 008/0-5, UNIMARC: 100a/0=7). 2. Duplicate the record by Edit > Edit as new (duplicate) 3. Control the 'date entered on file' value - it will equal to that of the original record. 4. Apply the patch (restart plack). 5. Repeat step 2. 6. Check the date - it should be the current date. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer commit c6641ef24f389e65a0dd90d3fd788f110f21158a Author: Kyle M Hall Date: Mon Mar 18 07:04:23 2024 -0400 Bug 34621: Tidy import_patrons.pl Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer commit 6a4c2dd03a99741129bd94e261d7681bd3e634de Author: Kyle M Hall Date: Mon Mar 18 07:00:37 2024 -0400 Bug 34621: Tidy Import.t Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer commit b89d744e868cd93632d6b84f5f39116a475d342e Author: Kyle M Hall Date: Fri Aug 25 17:37:46 2023 +0000 Bug 34621: implement Patron import option to 'Renew existing patrons' 'from the current membership expiry date' Test Plan: 1) Test importing a patron with the "from the current membership expiry date" option, note it does not work 2) Apply this patch 3) Restart all the things! 4) Re-test, note the expiration was renewed from the patron's current expiration date! Signed-off-by: David Nind Rebased-by: Victor Grousset/tuxayo Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer commit f3d2f34d7a6aeead30b40a30b239f15c6c94a7f2 Author: Nick Clemens Date: Mon Apr 1 14:32:08 2024 +0000 Bug 36473: Handle Invalid Metadata Exceptions in totalissues.pl This patch wraps the call for record in an eval, and catches any invalid metadata exceptions, letting the warning show, but allowing the script to continue To test: 1 - In default KTD record 369 has problems, otherwise you need to break a record 2 - Run : misc/cronjobs/update_totalissues.pl --use-stats --commit=1000 -v 3 - It dies at record 369 (or the one you broke) 4 - Apply patch 5 - Run again 6 - It succeeds, but skips the bad record Signed-off-by: David Nind Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer commit 9e9cc822cbd7836827a9596f71c50d5ad37f6802 Author: Laura Escamilla Date: Tue Apr 2 13:43:00 2024 +0000 Bug 36473: Unit tests Signed-off-by: Marcel de Rooy [EDIT] Tidied. Signed-off-by: Katrin Fischer commit 5d9396289e6ff754a79e5fad5f450144eb3a1c7c Author: Tomás Cohen Arazi Date: Tue Apr 2 12:53:45 2024 +0000 Bug 36483: Patrons.pm use case This case brought my attention as there was a different 'user' parameter being passed. It turns out we already thought about this, and `objects.to_api` is of course always passing it :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer commit 635e65a3303a01b90bbc93695b24c98720683f10 Author: Tomás Cohen Arazi Date: Tue Apr 2 12:43:51 2024 +0000 Bug 36483: Make API controllers use $c->objects->to_api This patch makes all controller methods using direct $object->to_api, rely on $c->objects->to_api. Direct ->to_api calling prevents things like embeds, +strings, etc to be dealt with correctly. In some cases this change reduces the code as the authors extracted the embed structure from the stash and passed it explicitly. I left out two Patrons.pm cases because I need to study it a bit more. To test: 1. Run: $ ktd --shell k$ prove t/db_dependent/api/v1 => SUCCESS: Tests pass 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests still pass! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer commit 9aa811c33481dddded624829dfd24643f31fc04d Author: Nick Clemens Date: Fri Apr 12 09:46:20 2024 +0000 Bug 23102: No mock in selenium Signed-off-by: Katrin Fischer commit 5bab87f76b05bbf8627cf6786975e9e30a5f2f6c Author: Nick Clemens Date: Wed Jun 12 11:43:48 2019 +0000 Bug 23102: 404 errors on page causes SCI user to be logged out To test: 1 - Have something on the SCO page that won't load Add to SCOUserJS: