commit 1030b6f971897fdc210c8fb64d4de50422a0b450 Author: Fridolin Somers Date: Tue Nov 28 09:02:20 2023 -1000 Update release notes for 23.05.06 release Signed-off-by: Fridolin Somers commit 873d285d55aaa8e1bc70f5a786261fa9a10e189e Author: Fridolin Somers Date: Tue Nov 28 08:24:44 2023 -1000 Increment version for 23.05.06 release Signed-off-by: Fridolin Somers commit 95538ae640504a4de17a43a904a22fc54cc8b0c8 Author: Owen Leonard Date: Thu Nov 9 19:46:35 2023 +0000 Bug 35290: (follow-up) Perltidy formatting corrections Signed-off-by: Nick Clemens Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 350aa94b5e4d5013429fa574ac1598ba4cab7c5c) Signed-off-by: Fridolin Somers commit 6f974adf0bbf1a05a7a5f3bd1c403f472cd5f4fa Author: David Cook Date: Wed Nov 8 23:39:45 2023 +0000 Bug 35290: Sanitize field input on cataloguing/ysearch.pl This change sanitizies the field input on cataloguing/ysearch.pl Test plan: 0. Apply the patch and restart/reload Koha 1a. "Add marc21_field_260b.pl plugin to 260$b in the Default framework" 1b. Go to http://localhost:8081/cgi-bin/koha/admin/marc_subfields_structure.pl? op=add_form&tagfield=260&frameworkcode=#subbfield 1c. Choose "marc21_field_260b.pl" from the dropdown next to "Plugin" 1d. Click "Save changes" 2a. "Add new record" 2b. Go to http://localhost:8081/cgi-bin/koha/cataloguing/addbiblio.pl?frameworkcode= 3. Click on tab "2" and scroll down to 260 "b" 4. Type in "Ori" into 260 subfield b 5. Some autocomplete suggestions should appear Signed-off-by: Owen Leonard Signed-off-by: Nick Clemens Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 4160afa3d74abb703ec1c461156f1b5a061480b3) Signed-off-by: Fridolin Somers commit ab5a62e2fc9fea9d750f6bd6ea36416eb116e4cc Author: Aleisha Amohia Date: Thu Nov 23 21:08:09 2023 +0000 Bug 35291: (QA follow-up) Tidying script for QA test tools Signed-off-by: Aleisha Amohia Signed-off-by: Tomas Cohen Arazi (cherry picked from commit b30898c8bf48b828080c557186dcb25b980ffb48) Signed-off-by: Fridolin Somers commit 8e4f99a9e70ab0d5ed2b66d52395b876ebefc2e3 Author: David Cook Date: Thu Nov 9 00:49:54 2023 +0000 Bug 35291: Validate filepaths in linking files Validate that the files in linking files are contained within the ZIP. Signed-off-by: Nick Clemens Signed-off-by: Aleisha Amohia Signed-off-by: Tomas Cohen Arazi (cherry picked from commit bae5256216f3ad911af3ef4dd944174448c85eaa) Signed-off-by: Fridolin Somers commit f62231c9df3eb65fd9b69b262230f89978fa06e0 Author: David Cook Date: Thu Nov 9 00:23:45 2023 +0000 Bug 35291: Don't allow symlinks for link files in cover image ZIP There's no reason to allow symlinks for link files in cover image ZIP files. Preventing their use prevents someone from uploading a symlink pointing to an existing file on the Koha server. Test plan: 0. Apply patch and restart/reload Koha 1. Create a PNG cover image 2. Create a datalink.txt file that contains something like the following: 29,Untitled.PNG 3. Turn on "LocalCoverImages" system preference 4. Upload via http://localhost:8081/cgi-bin/koha/tools/upload-cover-image.pl 5. Go to http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=29 6. Note the cover image has been uploaded Signed-off-by: Nick Clemens Signed-off-by: Aleisha Amohia Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 4b019fcbb041649bf4e19e95d59117fb9b422c05) Signed-off-by: Fridolin Somers commit 0c027ca4d562e9d64022cb446fcbba61809c8ee5 Author: Jonathan Druart Date: Wed Nov 8 17:14:55 2023 +0100 Bug 35291: Prevent leaks from FS Signed-off-by: David Cook Signed-off-by: Nick Clemens Signed-off-by: Aleisha Amohia Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 6023acd648110297a87c65d1b6d024584ac1bc06) Signed-off-by: Fridolin Somers commit 45512e188da7da01c95e3c8d3e4ec66845e91a1f Author: Mason James Date: Thu Nov 16 23:06:27 2023 +1300 Bug 35174: update control files for koha-l10n dependency package to test... - apply patch - build koha-common package - install koha-common package, and confirm koha-l10n package is installed Signed-off-by: Jonathan Druart commit 99bd5e1e6e2a9899f336c8f712f067b4370a6ba3 Author: Jonathan Druart Date: Thu Nov 16 08:45:15 2023 +0100 Bug 35174: Don't run gulp po commands if po dir is missing Signed-off-by: Jonathan Druart commit 513682492b52f860b97c2ecea979030b5e5e9281 Author: Jonathan Druart Date: Thu Nov 16 08:44:56 2023 +0100 Bug 35174: Add misc/translator/po to .gitignore Signed-off-by: Jonathan Druart commit 71ead49eb2e64f480c8c56ce2e80c3ad3199fd1e Author: Jonathan Druart Date: Thu Nov 16 08:43:43 2023 +0100 Bug 35174: Add a warning to the about page Signed-off-by: Jonathan Druart commit db3d56e7d1e1d280f221df51b567adb166f72b61 Author: Jonathan Druart Date: Thu Nov 16 08:27:10 2023 +0100 Bug 35174: Do not explode if po dir does not exist Signed-off-by: Jonathan Druart commit 5bdfa0b512ea16ae981e9997855722897691be9f Author: Koha translators <> Date: Wed Nov 22 09:32:36 2023 +0100 Bug 35174: Remove .po files from Koha commit ca5378cd946fd3c5496dab155ff112f0c245f71b Author: Nick Clemens Date: Mon Nov 13 16:02:46 2023 +0000 Bug 35307: Add a hidden input for expired holds To test: 1 - Place 3 holds on a bib, each for a different patron 2 - IN the db, set the first hold to be expired: UPDATE reserves SET expirationdate='2023-01-01' WHERE reserve_id=1; 3 - Refresh the holds page for the biblio 4 - Note the first hold now says 'Expired' in the expiration date column 5 - Set an expiration date for the last hold 6 - Click 'Update holds' 7 - Note the date is applied to the second hold 8 - Delete the holds 9 - Apply patch 10 - Repeat 1-6 11 - Confirm only the correct hold is updated Signed-off-by: David Nind Signed-off-by: Victor Grousset/tuxayo commit 7628952f426db8804ef41fbefc336831dcbcb288 Author: Marcel de Rooy Date: Mon Nov 6 13:11:49 2023 +0000 Bug 35266: Fix biblio check in opac-MARCdetail We should check before retrieving metadata. Test plan; Try /cgi-bin/koha/opac-MARCdetail?biblionumber=X Replace X by a not-existing biblionumber. Verify that you get a 404 error page. Signed-off-by: Marcel de Rooy Signed-off-by: David Nind JD amended patch: Use ternary op Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 54bdcaef66ef6b121918b8922020a50d1d0177c8) Signed-off-by: Fridolin Somers commit c8685d088aa03b0e64b073b2db001a2df5335819 Author: Marcel de Rooy Date: Thu Nov 9 13:16:05 2023 +0000 Bug 35012: Apply change to all events We should not just look at Click. Test plan: [1] Apply the example patch for a Blur action in barcode.pl. [2] Check that barcode.pl is active in your framework and that autoBarcode is not disabled. [3] Open the browser dev console. [4] Tab a few times through barcode in the neworderempty form of Acquisition. If you leave the field, the Blur event fires. => Without this patch you will see two console lines (FF may show a little '2' icon at the right side) added. With this patch just one. Signed-off-by: Marcel de Rooy Signed-off-by: Jan Kissig Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi (cherry picked from commit e9326f0e86881f95fd79b2dd7a2e9578ab517116) Signed-off-by: Fridolin Somers commit f846ee85ecbe7f75e9ba842a7cae905813c909d4 Author: Jan Kissig Date: Tue Oct 10 13:36:04 2023 +0200 Bug 35012: Prevent Click handler firing twice test plan: a) build a new basket + order line using "item create on placing an order" b) in the item creation dialog (neworderempty.pl) please use the webbrowsers dev tools to analyze the [...] button next to subfield d (Date acquired) and inspect the events that get fired by clicking c) notice the Clicktag_952_subfield_d_* event gets fired twice. d) apply patch and reload page e) there should be only 1 click handler left (besides the jquery one), which points to the Clicktag_952_subfield_* function Signed-off-by: Marcel de Rooy See also bug 35298. You may have seen that the Focus event of dateaccessioned did not fire. But that is related to use of Flatpickr in this plugin. Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi (cherry picked from commit ec3fe5d41e03d969b876f0948e81389b0a20df4c) Signed-off-by: Fridolin Somers commit 898e0d79793e8ff9450242e8e6b2f1f97e2873f8 Author: Marcel de Rooy Date: Tue Nov 7 13:57:42 2023 +0100 Bug 35276: Remove authentication params from suggestion hash These would be forwarded to Koha::Objects->as_list and crash on unknown column. Test plan: Logout from staff. Enter URL /suggestion/suggestion.pl Without this patch, it crashes. Now it does not. Note: The crash may show auth_forwarded_hash but I also saw koha_login_context passing by. Same issue. Signed-off-by: Marcel de Rooy Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi (cherry picked from commit e2821c7962ca7594f029f4c7fdb0c2f70028eb9b) Signed-off-by: Fridolin Somers commit 5ca56bf8b380644ddc35d5f72c8f14707489efdc Author: Marcel de Rooy Date: Thu Nov 9 08:05:34 2023 +0000 Bug 35298: Remove focus handler from dateaccessioned plugin. Test plan: Verify that setting focus to date acquired field in items editor fills date of today when field is empty but does not replace existing date. Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 0583deac95b35f1ad96493262e922d7ac3eef102) Signed-off-by: Fridolin Somers commit 3d122d220222931e1c61c4fedd09301d1780f0b9 Author: Jonathan Druart Date: Thu Oct 19 09:41:03 2023 +0200 Bug 35103: Add option to gulp tasks to pass a list of tasks You can now generate the messages.po for all languages with: gulp po:update --task messages or for only es-ES gulp po:update --task messages --lang es-ES It may be helpful for the "update po" script that will be used on weblate. Signed-off-by: Jonathan Druart commit fc0c87bf3c18c11c56160fc409cb8977eb12a1ea Author: Fridolin Somers Date: Mon Nov 13 09:12:08 2023 -1000 Bug 27992: [23.05] (follow-up) Fix unit test with unblessed patron commit c0750bc6beea86295e778c42a7a7a45a2145a11d Author: Fridolin Somers Date: Mon Nov 13 09:04:24 2023 -1000 Bug 21284: [23.05] (follow-up) Fix unit test with unblessed patron commit e867c7207bd16fb018052945cb83a146fa3192a1 Author: Jonathan Druart Date: Sat Nov 11 11:04:06 2023 +0100 Bug 35187: [23.05] (follow-up) Fix missing line breaks in WELCOME notice yaml was broken because of extra space commit e1dc14bb68d1a27447f6c09979dd75b184ff467a Author: Owen Leonard Date: Tue Nov 7 19:06:13 2023 +0000 Bug 35144: Update style of 'Required' label for OPAC patron attributes This patch makes some changes to style and markup of the part of the OPAC patron entry form which displays patron attribute entry fields. To test, apply the patch and rebuild the OPAC CSS. - Create at least two patron attributes which have both "Display in OPAC" and "Editable in OPAC" checked: One which is linked to an authorized value, one which isn't. At least one attribute should be mandatory. At least one attribute should be repeatable. - Test the form using either patron self-registration or by logging in to the OPAC and clicking the "Personal details" link in the sidebar. - Check the appearance of required fields in the form, including the mandatory patron attributes. - Confirm that the "Clear" and "New" controls look good and work correctly, including fields cloned with the "New" button. Signed-off-by: Lucas Gass Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi (cherry picked from commit dd70e43b66fc2a887c5a5d6afc165ebf20469354) Signed-off-by: Fridolin Somers commit fa1cabde11d40d2213b0dd1516fc2868021bac57 Author: Jonathan Druart Date: Tue Nov 7 11:23:34 2023 +0100 Bug 35273: Fix item selection when receiving For partial receives with items created on order, the aqorders_items table was not correctly updated when only some of the ordered items were received. To test: 1) Create a basket with creating items on order 2) Create an order line with 3 items 3) Close basked 4) Receive shipment and create invoice 5) Receive your created order line 6) Edit first item displayed, add barcode 7) Check checkbox and receive 8) Verify the order line has been split 2:1 9) Receive again - notice all 3 items are showing. We should only see the remaining 2 10) Undo receive 11) Apply patch 12) Repeat steps 5)-9) 13) Verify that in step 9) only the remaining 2 items display now. Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 4fd674761199c2cce6ffbd0c272ee22f19711c4f) Signed-off-by: Fridolin Somers commit 6cb8aa14ac987d944615288eb72092ec87c4b970 Author: Thibaud Guillot Date: Fri Nov 3 15:30:04 2023 +0100 Bug 29007: Add cancellation reason input on check in Test plan: 1) Check an item in with already a confirmed hold 2) Cancel the hold, it was cancelled without possibility to choosing a reason 3) Apply this patch and do it again, you must see an input to choose your cancellation reason (list from VA) Signed-off-by: David Nind Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi (cherry picked from commit fe93b31ec73f22712189f9e4d385ec453b1cbd5a) Signed-off-by: Fridolin Somers commit 712d09b7ccd6b7405362ec961cfe195c5dce7391 Author: Jonathan Druart Date: Thu Nov 9 10:45:32 2023 +0100 Bug 35284: Fix tests This fix patrons_search.t but other selenium tests certainly need adjustements Signed-off-by: David Cook Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi (cherry picked from commit dbf07b8cd3143660449cc49d855d2ceca56a42fe) Signed-off-by: Fridolin Somers commit 159e5c6bca0b6e797e43c1c00452cb563b51cc85 Author: Jonathan Druart Date: Thu Nov 9 08:58:41 2023 +0100 Bug 35284: Add throttling to column filters Signed-off-by: David Cook Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 5220dd6004ff34d29c29e1e139d6d17ccecff9b4) Signed-off-by: Fridolin Somers commit 4d6ae9da14c0371d5f343680838ba86657ad3230 Author: Jonathan Druart Date: Thu Nov 9 08:58:11 2023 +0100 Bug 35284: Fix Vue tables Signed-off-by: David Cook Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 8738dcd9886cdb5d91e481e11d0d1c730a9e9127) Signed-off-by: Fridolin Somers commit 857637ddb4dddece39b2e319cbd432626e1ac952 Author: Jonathan Druart Date: Wed Nov 8 22:23:20 2023 +0100 Bug 35284: Add DT delay to kohaTable To test: * When a specific initComplete exists (general patron search) * When no specific initComplete exists (cities) => KO * ERM tables display twice the "show X entries" dropdown list * Column filters are not affected Signed-off-by: David Cook Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 3819f4a57c9c208746e7f147ab085c36ccaf7d68) Signed-off-by: Fridolin Somers commit 34672f0ca452244b7e645540c0aad2df21ca86fe Author: David Cook Date: Fri Nov 10 01:06:39 2023 +0000 Bug 35008: (QA follow-up) Add selenium unit tests This patch addds selenium tests for the ILS-DI feature. Signed-off-by: Tomas Cohen Arazi (cherry picked from commit a89aee37239495a7a655d99a3a910ecdd3fce835) Signed-off-by: Fridolin Somers commit 278a0963f7f03205a2e45daa0d0417a2c113d87c Author: Aleisha Amohia Date: Sun Oct 8 21:59:19 2023 +0000 Bug 35008: Make ILS-DI not require auth when OpacPublic disabled To test, disable OpacPublic and ensure a call to ilsdi.pl will still return expected results from a private browser, not logged into the OPAC. Sponsored-by: Auckland University of Technology Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi (cherry picked from commit eb130f559ecc0a232adce9a8af0084a99d6e9a81) Signed-off-by: Fridolin Somers commit 916f7d9127e4bd1f679b1f1a0c54802a1869f1e7 Author: Katrin Fischer Date: Thu Nov 9 21:33:10 2023 +0000 Bug 35283: Add missing subfield h to action note 583 in OPAC detail page $x is nonpublic note, so it makes sense to only display it in staff, but $h is Jurisdiction and we should show it in OPAC and staff alike. Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 653dc1b2214d0ebb291766406354c69cfa57c7e1) Signed-off-by: Fridolin Somers commit ba9a11341041bc6fed3fb8c0ef7bf1f54d51c954 Author: David Cook Date: Wed Nov 8 02:24:01 2023 +0000 Bug 35283: Add missing subfields h and x to field 583 for staff XSLT This change adds the missing subfields h and x to field 583 for the detail XSLT in the staff interface. Test plan: 0. Apply the patch and koha-plack --reload kohadev 1. Go to http://localhost:8081/cgi-bin/koha/cataloguing/addbiblio.pl?biblionumber=29 2. Click on tab "5" 3. Scroll down to 583 and click on "ACTION NOTE" to expand subfields 4. Fill in using the following example: 583 0#$adowngraded$c19910110$hJoe Smith$otitle$xfrom secret FRD to confidential NSI 5. Click "Save" 6. Note that the "Action note" now shows "Joe Smith" and "from secret FRD to confidentail NSI" Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi (cherry picked from commit d74a89e2dabe355f05c4c45b6b39e581509e1c16) Signed-off-by: Fridolin Somers commit 53370581fdfedd8232bd7bd3f4f9c81f7c56ad34 Author: Aleisha Amohia Date: Mon Oct 23 22:28:55 2023 +0000 Bug 33164: Do not prevent processing of all error messages This follow-up patch removes the use of $exit_required_p completely. The sysprefs BlockReturnOfLostItems and BlockReturnOfWithdrawnItems are handled in other scripts, and should not prevent the processing of all returns error messages when enabled. Signed-off-by: Phil Ringnalda Signed-off-by: Emily Lamancusa Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 64460e4f4e01d8cb84a8037f444e5f7739a6bd40) Signed-off-by: Fridolin Somers commit 93276f59f14a293fdd639a6185577287693cd50c Author: Aleisha Amohia Date: Wed Mar 8 11:07:04 2023 +1300 Bug 33164: Ensure return claim message shows if lost item return blocked This fix ensures that a return claim confirmation always shows, even if the return of lost items has been blocked by BlockReturnOfLostItems being enabled. To test: 1. Set BlockReturnOfLostItems system preference to Block 2. Check out an item to a patron 3. Go to the patrons page and claim a return on the item 4. Check in the item and keep checking in the item. Notice the message "Item is lost, cannot be checked in." shows every time, but the return claim message only shows sometimes. 5. Apply the patch and restart services 6. Check in the item and keep checking in the item. Confirm both the lost message shows and the return claim message shows every time. 7. Confirm the return of the item is still blocked. Sponsored-by: Pymble Ladies' College Signed-off-by: Phil Ringnalda Signed-off-by: Emily Lamancusa Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 1f56880812323a003d3d9d043c10c3142d397ac4) Signed-off-by: Fridolin Somers commit dbc24ece694b2bc1a56e32ff663765b1f1dd5d1b Author: Marcel de Rooy Date: Mon Nov 6 14:00:49 2023 +0000 Bug 35278: Fix warn from column_settings.pl We need to add scalar to the calls. These parameters are not meant to be used as multi_param. Test plan: Try With and without this patch on staff: Try: /cgi-bin/koha/admin/columns_settings.pl => WITHOUT: No warnings => WITH: Same. No change. Try: /cgi-bin/koha/admin/columns_settings.pl?module=acqui&page=basket => WITHOUT: Opens module, scrolls down. CGI::param called in list context in logfile => WITH: Opens module, scrolls down. Try: /cgi-bin/koha/admin/columns_settings.pl?module=acqui&page=basket&table=orders => WITHOUT: Opens module, scrolls down. CGI::param called in list context in logfile => WITH: Opens module, scrolls down. Try: /cgi-bin/koha/admin/columns_settings.pl?module=acqui&module=admin * Hash like: panel => acqui, admin => page, undef => table, undef => modules, $modules (SHIFTED) => WITHOUT: Acqui expanded showing: There is no page using the table configuration in this module. => CGI::param warning in log. => And: Problem = a value of table has been passed to param without key => And: Problem = a value of modules has been passed to param without key => WITH: Only the first module (Acqui) should be expanded. Try: /cgi-bin/koha/admin/columns_settings.pl?module=acqui&module=admin&page=basket&table=orders * Hash like: panel => acqui, admin => page, basket => table, orders => modules, $modules hash (SHIFTED) => WITHOUT: Acqui expanded showing: There is no page using the table configuration in this module. => And: CGI param log warning. => WITH:: Opens Acqui. Second module ignored. Scrolling. Try: /cgi-bin/koha/admin/columns_settings.pl?module=admin&module=acqui&page=basket&table=orders * Hash like: panel => admin, acqui=> page, basket => table, orders => modules, $modules hash (SHIFTED) => WITHOUT: Admin expanded showing: There is no page using the table configuration in this module. => And: CGI param log warning. => WITH: Admin should be expanded (page and table ignored, not in Admin). No scroll. Signed-off-by: Marcel de Rooy Signed-off-by: David Nind Signed-off-by: Emily Lamancusa Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 1b11de87b991ddae4d31861c9cdc321ce45d229d) Signed-off-by: Fridolin Somers commit 0b468bd4139b1d35e87e0ff44b6f5e48ca26641d Author: Owen Leonard Date: Thu Nov 9 13:21:06 2023 +0000 Bug 34413: Fix style of Flatpickr in iOS mobile view This patch updates Flatpickr CSS in the OPAC and staff interface so that date fields are displayed correctly in iOS mobile views. To test, apply the patch and rebuild the OPAC and staff interface CSS. - In the OPAC, click "Create new account" - In the account entry form, confirm that the date of birth field looks correct and that the date-picker works as it should. - In the staff client, go to Patrons -> New patron. - Check the date of birth field in this form too. This patch has been tested in the Xcode iOS device simulator with iOS 17. While I wasn't able to reproduce the problem in Firefox, I was able to use the developer tools' responsive design mode to trigger the mobile view and thus be able to see the styles which are being applied: - In the OPAC, on the "Create new account" screen, open the Web Developer Tools panel (Tools -> Browser tools -> Web Developer Tools). - Click the "Responsive Design Mode" button in the upper-right corner of the developer tools panel (it looks like a phone and tablet together). - The main browser window will now how some settings at the top. - In the first dropdown, choose an iPhone model. - The date of birth field should now be styled differently because of the addition of a "flatpickr-mobile" style. - Right-click the field and choose "Inspect." In the developer console you can see the styles which are being applied to the field. One of those should be ".flatpickr-input.flatpickr-mobile" Signed-off-by: Lucas Gass Signed-off-by: Emily Lamancusa Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 9e9fa64d5a9f8966c45a923b258c994df70ac35f) Signed-off-by: Fridolin Somers commit 6abfcbecd878bb634b129df59c345f2c80c4955f Author: Lucas Gass Date: Wed Nov 8 21:18:27 2023 +0000 Bug 35295: Move JS asset in returns.tt To Test: 1. Place a hold 2. Check-in an item of the held record 3. No hold modal 😱 4. APPLY PATCH 5. Hold modal!!! Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 771334218acc2a5eb97bac1eab38a53543084444) Signed-off-by: Fridolin Somers commit 200732f2cfa19ac0466f933fad980d89dda35e09 Author: Nick Clemens Date: Fri Nov 3 20:10:01 2023 +0000 Bug 35254: Add import_record_id to order inputs This patch follows the logic of bug 32166 and adds specific inputs for each order to avoid any misalignment when some records are not imported To test: 1 - Find a vendor in acquisitions 2 - Create or find an open basket 3 - Add to basket form a new file 4 - Stage file and add to basket 5 - Select the second record in the list 6 - Enter price info 7 - Save (don't forget, you need to set item type in the second tab) 8 - The order has no price info! 9 - Apply patch 10 - Repeat 3-7 above, staging file fresh 11 - Confirm order has correct prices 12 - Test with a file with many records 13 - Confirm any combination of choosing/skipping records works as expected Signed-off-by: Katrin Fischer Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 7e2f6d66d6a8cae55d3c879ec2ce89af59439ffa) Signed-off-by: Fridolin Somers commit 4e34b92112df0e97d7a4fcc72c5bd95ca7c202dd Author: Owen Leonard Date: Mon Nov 6 19:40:06 2023 +0000 Bug 35262: Improve OPAC self registration confirmation page This patch corrects logic in the OPAC self registration confirmation template so that the right column markup is shown when various combinations of OpacNav, OpacNavBottom, and OpacNavRight are displayed. To test, apply the patch and enable the PatronSelfRegistration system preference, and deactivate the PatronSelfRegistrationVerifyByEmail preference. - Go to the OPAC and start the process of registering online. - Fill in the form and submit it. - On the registration confirmation page, check that the layout looks correct. - Test with the presence of various combinations of OpacNav, OpacNavBottom, and OpacNavRight HTML customizations. Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 64edb692458262133818553c4cbfa86ca3612260) Signed-off-by: Fridolin Somers commit b7cb356363d09c1bb1839165cbc4d090c47317ea Author: Owen Leonard Date: Tue Oct 31 17:10:15 2023 +0000 Bug 35206: Adjust style of add button on curbside pickups administration This patch adds Bootstrap classes to the "Add" button on the curbside administration page, in the "Curbside pickup hours" section. This makes it consistent with the markup of similar buttons in the interface and makes it slightly smaller so that it fits better in the form. To test, apply the patch and make sure the "CurbsidePickup" preference is enabled. - Go to Administration -> Curbside pickups. - Fill out the form, including the "New slot" fields in the "Curbside pickup hours" section. - Confirm that the corresponding "Add" button looks correct, and that it works to add your new slot. Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi (cherry picked from commit cc70e17f5d07ad8988a1a4a02e0049abc7428547) Signed-off-by: Fridolin Somers commit b3a0111913834a0946e488781db866a38dba2cea Author: Tomás Cohen Arazi Date: Wed Nov 8 17:36:37 2023 -0300 Bug 34328: DBRev 23.05.05.003 Signed-off-by: Tomas Cohen Arazi (cherry picked from commit f4001d5462a3490d04e65b3cf7a45174b9eb4b86) Signed-off-by: Fridolin Somers commit a6fcce30f92b3d9d9e32a8bb7cd44b20134e9175 Author: Martin Renvoize Date: Fri Oct 6 10:41:20 2023 +0100 Bug 34328: Make update idempotent Signed-off-by: Katrin Fischer Perltidied the atomic update. Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 1dd482bb8ebf7091dfff913ad9dc8f8a0e6f328d) Signed-off-by: Fridolin Somers commit 09df56991aaef077a315d23f94a9eab5ad1fe694 Author: Martin Renvoize Date: Fri Jul 21 08:21:23 2023 +0100 Bug 34328: (follow-up) Add description to en_GB This follow-up adds the language description string for Scottish Gaelic to the en_GB translation. Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 037619ab95d502086fe9727536fad9496301d2e1) Signed-off-by: Fridolin Somers commit 26854910bb2fb50daa74a46fa32004dba564f04e Author: Martin Renvoize Date: Thu Jul 20 16:31:40 2023 +0100 Bug 34328: Add Scottish Gaelic to languages Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 44aa68c3dfa2b067b317cdb1c6578e517e115d46) Signed-off-by: Fridolin Somers commit 1ec1364c13645d808d273a09efb1613637670e44 Author: Kyle M Hall Date: Fri Nov 3 16:45:22 2023 +0000 Bug 21284: (QA follow-up) Fix QA script issues Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi (cherry picked from commit db19d3f18d8eaffce7def6adc6c86941b9d33d34) Signed-off-by: Fridolin Somers commit a63fd09475e7c4b299e1f87ccba812d0fe017047 Author: Kyle M Hall Date: Fri Nov 3 16:43:47 2023 +0000 Bug 21284: (QA follow-up) Rename itemonhold and recordonhold Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 37c8cf6e34de8db5a3147ffed9cfa96e075080f1) Signed-off-by: Fridolin Somers commit 1b4cd9eeaad48e890fc86f073114beecca0e6b31 Author: Matthias Meusburger Date: Fri Apr 27 16:22:28 2018 +0200 Bug 21284: ILS-DI: Allow GetPatronInfo to tell if a loaned item is on hold by someone else. This patch adds two new entries in the loans section of GetPatronInfo response: - itemonhold: number of holds on this specific item. - recordonhold: number of holds on the record. It allows an ILS-DI client to know if a loaned item is already on hold by someone else, and how many holds there are. Test plan: 1. Apply the patch. 2. Enable the ILS-DI system preference. 3. Check out an item for a patron and make sure there no other holds at either an item or record level. 4. Check that the new itemonhold and recordonhold entries displayed are equal to zero (example: http://127.0.0.1:8080/cgi-bin/koha/ilsdi.pl?service=GetPatronInfo&patron_id=19&show_contact=0&show_loans=1). 5. Add either a record or item level hold for the record used in step 2. 6. Check that itemonhold and recordonhold values are incremented accordingly. Note: a hold at an item level counts as a hold at a record level, but not vice-versa. 7. Run the tests and make sure they pass: prove t/db_dependent/ILSDI_Services.t 8. Sign-off! Signed-off-by: David Nind Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi (cherry picked from commit d1d5811279fe6a2c8fc0953142fffe3adc9f249b) Signed-off-by: Fridolin Somers