commit 5f5206d0e56de223513ebb2e0ed5f7908a15ff83 Author: Tomás Cohen Arazi Date: Mon Nov 11 13:48:51 2024 -0300 Bug 38418: Make SIP/Transaction.t run on all dateformat values To test: 1. Change the `dateformat` syspref to any value other than `us`(shows as mm/dd/yyyy) 2. Run: $ ktd --shell k$ prove t/db_dependent/SIP/Transaction.t => FAIL: Tests fail because of the resulting string containing an unexpected date format. 3. Repeat 1-2 with other formats => FAIL: SAme 4. Choose `us` 5. Repeat 2 => SUCCESS: It passes 6. Apply this patch 7. Repeat 2 => SUCCESS: Tests pass! Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 479df408fc42d6a226ea023c71dead6d7e37caba Author: Phil Ringnalda Date: Fri Nov 1 11:22:59 2024 -0700 Bug 38328: Cannot delete ILL batch statuses You are permitted to delete ILL batch statuses that you (rather than the system) add, but the UI didn't get the CSRF memo about delete ops needing to be POSTs with op="cud-delete", so it still uses a GET of ?op="delete" and fails. Test plan: 1. Set the preference ILLModule to 'Enable' 2. Administration - Interlibrary loan batch statuses - New batch status 3. Give it a name, an uppercase code, and Save 4. Click the Delete button to the right of your new status 5. The page is blank, and if you navigate back to Interlibrary loan batch statuses, you'll see that yours was not deleted 6. Apply patch, reload page 7. Click the Delete button to the right of your new status, verify it is deleted Sponsored-by: Chetco Community Public Library Signed-off-by: Sam Sowanick Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit a9e7e8f14d68be2642394fcafad15c4d7f01ca7d Author: Martin Renvoize Date: Wed Nov 13 09:35:50 2024 +0000 Bug 38322: (QA follow-up) Fix spelling Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 0e899b8882273c9b80fae267398c90bb314ad4dc Author: Nick Clemens Date: Fri Nov 1 12:54:09 2024 +0000 Bug 38322: Adjust tests Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 1c1b87690cdf027a9f4242b1eef50c4e45e08ce7 Author: Jonathan Druart Date: Wed Nov 13 12:46:41 2024 +0100 Bug 38069: Fix jump to the correct table Signed-off-by: Katrin Fischer commit 9b8ea2dc6ac7ed7d590fd0678a09fbc1f20f2a1c Author: Pedro Amorim Date: Wed Nov 13 11:01:53 2024 +0000 Bug 36221: (QA follow-up): Fix translation entry concat Signed-off-by: Katrin Fischer commit d95337ac5545c010666533f138f70d0497b70866 Author: David Cook Date: Wed Nov 13 00:10:11 2024 +0000 Bug 34088: (follow-up) fix env vars in koha-upgrade-schema Signed-off-by: Phil Ringnalda Signed-off-by: Katrin Fischer commit 1a9dfde6679c7fbcfc78c7cac69473c6c8d539f7 Author: Jonathan Druart Date: Wed Nov 13 15:45:56 2024 +0100 Bug 28633: Fix patrons_search.t This does not belong here, but raised to me here, so attaching on this one. This feels like it's coming from bug 33484, but those tests were passing after it has been pushed. This patch fixes the following error: Error while executing command: stale element reference: The element reference of is stale; either the element is no longer attached to the DOM, it is not in the current frame context, or the document has been refreshed at /usr/share/perl5/Selenium/Remote/Driver.pm line 411. Since bug 33484 the row with the filters is redrawn on table redraw. So we need to search for the input every time the table is redrawn. Signed-off-by: Katrin Fischer commit cfb841f9e6abc56735f8567ec40f46702cda9786 Author: Jan Kissig Date: Thu Nov 7 13:32:05 2024 +0000 Bug 23426: (follow-up) Enhance sip_cli_emulator.pl for test plan This follow up enhances the sip_cli_emulator.pl to use start-item and/or end-item as params. With these new params the original test plan can be extended: Test plan: a) create several manual invoices for patron 23529000035676 : http://localhost:8081/cgi-bin/koha/members/maninvoice.pl?borrowernumber=19 b) run perl misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su term1 -sp term1 -l CPL --patron 23529000035676 -m patron_information -s " Y " --start-item=1 --end-item=2 to get fine 1 and 2 or perl misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su term1 -sp term1 -l CPL --patron 23529000035676 -m patron_information -s " Y " --start-item=3 --end-item=3 to retrieve fine 3 Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit e5bd8aec41cb8f7ade5f7a228bbb34ff40ecea5b Author: Jan Kissig Date: Thu Nov 7 12:42:59 2024 +0000 Bug 23426: (follow-up) This patch reintroduces the former implementation of fine items The original implementation of fine items was accidently overwritten with this patch. This follow up reverts these changes but keeps additional improvements that were also part of this patch. These are: - Returning the active currency as part of the response (BH) - Fixing the number of items in the response which are specified in BP and BQ when other items as fine items are requested. Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit cb4c2af29ff5565810c9d1e32d615cab30be88ae Author: Katrin Fischer Date: Wed Nov 13 15:31:22 2024 +0000 Revert "Bug 38391: Redraw the filters row on table redraw" This reverts commit af6b0510d7f00fae32f001afb2aaccd9064a9092. Signed-off-by: Katrin Fischer commit 733e353512996464ce4227dc8dec3673fa772023 Author: Katrin Fischer Date: Tue Nov 12 16:34:30 2024 +0000 Bug 36221: (QA follow-up) Capitalization: Please Note Signed-off-by: Katrin Fischer commit 407fe2fa561d45e7cfff89e7b38c2ffd2f8e44ec Author: Owen Leonard Date: Mon Nov 11 18:17:13 2024 +0000 Bug 36221: (follow-up) Style and markup fixes This patch makes several changes to make the updated forms more consistent with how other pages work: - Form labels should have ":" after them. - Form fields should have a hint when they are required. - Required fields should not be indicated with an asterisk. - In the OPAC, It was missing in the JS that adds new empty custom fields. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Katrin Fischer commit 3c74dac38d8028fcb3c6484ded63a398b4a9ae00 Author: Pedro Amorim Date: Tue Nov 5 11:16:01 2024 +0000 Bug 36221: (QA follow-up): Fix opac check To address Victor's comment #32 Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Katrin Fischer commit 742a56944ec02da6277ca4c1569e608df4f6f835 Author: Victor Grousset Date: Tue Nov 5 10:15:25 2024 +0100 Bug 36221: (QA follow-up): add placeholder attr to staff custom fields In the prepopulated fields when editing item metadata that had custom fields (tt generated). So it's consistent when adding new empty fields (done in JS) Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Katrin Fischer commit 954721686083d7c17b28eda500c234daafcf1980 Author: Pedro Amorim Date: Mon Nov 4 17:01:18 2024 +0000 Bug 36221: (QA follow-up): Fix translatability in JS concat Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Katrin Fischer commit 588207c4e9c340e649cde6a105517339cc090763 Author: Pedro Amorim Date: Mon Nov 4 15:25:10 2024 -0100 Bug 36221: (QA follow-up): Fix incorrect input type on HTML Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Katrin Fischer commit 73dbed8b914d7c1b6321545527844c4cf4e16a74 Author: Pedro Amorim Date: Wed Oct 30 09:34:49 2024 +0000 Bug 36221: (QA follow-up): Fix year value Signed-off-by: Martin Renvoize Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Katrin Fischer commit da12be63cb905e1357d966b4cd3109dd3cfd1c48 Author: Pedro Amorim Date: Mon Mar 4 14:18:21 2024 +0000 Bug 36221: OPAC Styling Test plan, dont apply patches yet: 1) Enable ILLModule 2) Create a new OPAC ILL request, visit: /cgi-bin/koha/opac-illrequests.pl?method=create&backend=Standard 3) Notice the style. Apply patches. Repeat Signed-off-by: Lisette Scheer Signed-off-by: Martin Renvoize Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Katrin Fischer commit cfdb7f0652ada96219a6966c82c7fdbf73b4a000 Author: Pedro Amorim Date: Mon Nov 4 15:28:11 2024 -0100 Bug 36221: (QA follow-up): Apply styling improvements to DVD qa tools throw: ill_text_input_field: not found But I believe this is a false positive. We can clearly see it working by going to: http://localhost:8080/cgi-bin/koha/opac-illrequests.pl?op=add_form&backend=Standard And picking 'DVD' or any other type. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Katrin Fischer commit ba3752db8ecea61212deaee3de3dc4ede645410c Author: Pedro Amorim Date: Fri Mar 8 15:21:16 2024 +0000 Bug 36221: Move patron section to top of create form Signed-off-by: Martin Renvoize Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Katrin Fischer commit 712c72db8c768a6ce4135284883daf5958b4012e Author: Pedro Amorim Date: Mon Mar 4 14:20:35 2024 +0000 Bug 36221: Preparation This refactors the code for more DRY Signed-off-by: Lisette Scheer Signed-off-by: Martin Renvoize Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Katrin Fischer commit 05bf35c83fcbd05064436629f7bf6cf75041be36 Author: Pedro Amorim Date: Mon Nov 4 13:16:45 2024 +0000 Bug 35570: (QA follow-up): Fix translatability of 'Delete' This is also fixing the delete->trash icon and spacing between label+icon Signed-off-by: Katrin Fischer commit a5358f4c54bdb06ca1c9bb08a719ea4dd76116cc Author: Pedro Amorim Date: Mon Nov 4 13:16:17 2024 +0000 Bug 35570: (QA follow-up): Fix terminology Signed-off-by: Katrin Fischer commit 5a1f0fad05beadf501420c55cea4706dd84a0a73 Author: Pedro Amorim Date: Mon Nov 4 13:15:34 2024 +0000 Bug 35570: (QA follow-up): Fix styling of confirmation buttons Signed-off-by: Katrin Fischer commit bb5dcdfe03717930435d5af8fb1854517037a55b Author: Owen Leonard Date: Tue Nov 12 13:02:43 2024 +0000 Bug 38383: (follow-up) Undo global text-info change Adding an !important override to installer.scss isn't ideal but it's an acceptable interim solution pending a more thorough review of how we customize Bootstrap's text-* classes. Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 8248ec11b5e0d4d4dc02a5e6dce9f11df9e844c6 Author: Emily Lamancusa Date: Fri Nov 8 15:49:22 2024 -0500 Bug 38383: Improve font color contrast on web installer Update the font colors for info, warning, and database errors on the web installer to meet WCAG accessibility guidelines for color contrast. For the yellow text, it is impossible to meet minimum contrast levels on a white background without losing the yellow-ness of the yellow. This patch opts for a dark text color with a light yellow highlight, to meet contrast standards while allowing the yellow to be easily distinguished from other message colors. To test: 1. Apply patch for test dbrev 2. Trigger a database update from the web installer In KTD this can be done by: i. Changing the Version system preference to a slightly lower number (for example, from 24.0600057 to 24.0600056) ii. Reload the staff client iii. Log in with koha_kohadev, password --> Note that the blue and yellow colors are very light 3. If possible, use browser tools to check the accessibility of the different colors of text (in Firefox, right click on the text and choose "Inspect accessibility properties") --> Note that some of the text does not meet WCAG accessibility standard 4. Apply this patch and yarn build 5. Clear browser cache and refresh the page --> Note that the blue and yellow text is more readable 6. If possible, repeat step 3 --> Note that all text now meets WCAG standards Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 0ed10ee3da7132388cc422b82ddc284ff6871fbc Author: Pedro Amorim Date: Mon Jul 1 10:30:08 2024 +0000 Bug 37178: Disable sorting on comments column Signed-off-by: Lucas Gass Signed-off-by: Paul Derscheid Signed-off-by: Katrin Fischer commit fb0f1efebaf149d8a17f016d5548fd269c081554 Author: Janusz Kaczmarek Date: Tue Oct 22 11:39:09 2024 +0000 Bug 38235: Unit tests BTW, tiny adjustments to existing tests to work with modified C4::Suggestions::ModSuggestion. Signed-off-by: Roman Dolny Signed-off-by: Aleisha Amohia Signed-off-by: Katrin Fischer commit 97ce4ab029a335b44ce13fe91fa5970d33608502 Author: Janusz Kaczmarek Date: Tue Oct 22 11:00:09 2024 +0000 Bug 38235: Suggestion confirmation letter sent when it should not When processing a new order (creating basket, receiving order, etc.) using a bibliographic record once already linked to an old suggestion (already completed in the past), Koha generates and sends a confirmation letter that should not be sent at all. This is because suggestions in Koha are linked to a biblionumber (and not the order), and so the old suggestion is identified - erroneously - as relevant. Then C4::Suggestions::ModSuggestion sends a letter whenever it receives STATUS as a parameter, paying no attention to whether the status is changed. So, in this case, a suggestion already in the status AVAILABLE is "updated" to the status AVAILABLE and the letter is generated. To solve this problem, it should be enough to check whether STATUS is actually changed. Test plan: ========== 1. As a patron, make a purchase suggestion. As a librarian, accept it and process it, as usual, through the acquisition process. 2. At the patron account, as librarian, check the generated notices (the most recent should be "Suggested purchase available"). 3. Make a new aquisition order for the same bibliographic record ("From an existing record:") and receive it as usual. 4. Go to the account of the patron that made the original suggestion and check the notices. Note the second, irrelevant letter "Suggested purchase available". 5. Apply the patch; restart_all. 6. Repeat p. 3 and 4. Note that no new notice has been generated. Sponsored-by: Ignatianum University in Cracow Signed-off-by: Roman Dolny Signed-off-by: Aleisha Amohia Signed-off-by: Katrin Fischer commit 0ab32306eee1572e259567f855a3a7fe8c4976e4 Author: Jonathan Druart Date: Thu Nov 7 11:33:03 2024 +0100 Bug 38385: Improve DB update output on error (UI) When an error occurred during the DB update the UI is not correct. 1. say_success, say_info, etc. show the span tags and are not colored 2. "Everything went okay" shown even if atomic updates failed 3. The same error can be displayed several time (see https://snipboard.io/IGiKgM.jpg) Test plan: Create a new db rev and/or atomic update Have some say_* statement to render messages, and raise an error For instance: say_info( $out, "Use blue for further information" ); try { say_warning( $out, "Use yellow for warning/a call to action" ); $dbh->do(q{}); } catch { say_failure( $out, "Use red for danger/failure" ); $_->rethrow; }; Signed-off-by: Emily Lamancusa Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 2152ac1c66c3ebda401ed490f23970bcecf5ac0a Author: Martin Renvoize Date: Tue Nov 12 07:41:03 2024 +0000 Bug 38011: (QA follow-up) Improve database update output Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit f20582bb0d1aac62d8a8debf8a8322112e4b42a5 Author: Pedro Amorim Date: Mon Oct 21 11:33:46 2024 +0000 Bug 37850: (QA follow-up): Update illemail REST API attribute name To test 1) yarn api:bundle && koha-plack --restart kohadev 2) Enable ILLModule and put some 'ILL staff email:' on some library 3) Access /api/v1/libraries 4) Notice the attribute reads ill_email Signed-off-by: Katrin Fischer commit 1e1b766480911269b9b0d79c7f69b105e8f48424 Author: Pedro Amorim Date: Tue May 7 12:45:24 2024 +0000 Bug 36182: Show vendor name if acquisition_source is a vendor_id This will make it so if acquisition_source is of an existing vendor_id, it'll show the vendor name instead of the id. If it's not of an existing vendor_id, show the raw value instead. I'm not 100% happy with this patch as it adds an edge case to Item::strings_map but I believe the only alternative is to make 952$e Source of acquisition an AV field in the default framework. Not only that, but this would have to be an AV field of type 'vendors' that'd have to allow to pick from existing vendors (similar to current 'branches'). The above is a ton more work than initial suggestions would imply. Happy to be proven wrong (in fact, hoping I am). This is compatible with main Koha only, not backportable to 23.11 Signed-off-by: Katrin Fischer commit 58a471610ab05248bd68e17700a5a8aebcf08771 Author: Pedro Amorim Date: Mon Apr 22 11:21:20 2024 +0000 Bug 36182: Add booksellerid columns to holdings table 1) Apply patch, reset_all 2) Configure holdings_table, visit: /cgi-bin/koha/admin/columns_settings.pl?module=catalogue&page=detail&table=holdings_table 3) Confirm holdings_booksellerid is there and is hidden by default 4) Visit a record: /cgi-bin/koha/catalogue/detail.pl?biblionumber=76 5) Edit one of the items and add a value to field 'e' Source of acquisition 5.5) You may need to click the 'show filters' link in order to have the 'Columns' table button show up 6) Go back to the record and click on the 'Columns' above the table 7) Click 'Source of acquisition'. Confirm it shows as expected Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer commit d7fa540195c23a569a73e298959ddb007cb297f1 Author: Nick Clemens Date: Tue Nov 12 14:47:07 2024 +0000 Bug 28633: (follow-up) Set preferred name and adjust counts for tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer commit ce5c7695e24738d23dd658c514517a19ee660f5b Author: Martin Renvoize Date: Thu Nov 7 12:59:40 2024 +0000 Bug 38390: Add subscriptions+count to vendors embed This patch adds the subscriptions+count option to the embeddable enum for the /vendors endpoint. Test plan 1) Inspect the change to t/db_dependant/api/v1/acquisitions_vendors.t and confirm it's testing for the addition of subscriptions_count. 2) Run the above tests and confirm it passes Note: For the above tests to pass, you will need to ensure your api bundle is rebuilt after the patches are applied and restart plack. `yarn build && restart_all` in ktd Signed-off-by: Matt Blenkinsop Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer commit 30bec5bb98242ea49d60dbab632ad17f8e524392 Author: Katrin Fischer Date: Mon Nov 11 16:11:37 2024 +0000 Bug 34355: (QA follow-up) Terminology and capitalization Signed-off-by: Katrin Fischer commit 1656998d50339d5a0a97191f7cdf06eba74e9065 Author: Katrin Fischer Date: Mon Nov 11 15:38:07 2024 +0000 Bug 34355: DBIC schema update Signed-off-by: Katrin Fischer commit c1c19672f78fca39882c538d4ade9edd5112795f Author: Katrin Fischer Date: Mon Nov 11 15:28:32 2024 +0000 Bug 34355: DBRev 24.06.00.062 Signed-off-by: Katrin Fischer commit d8c02117a38f248fc47fafae11d6a2ce95b79bfc Author: Nick Clemens Date: Tue Nov 5 16:32:50 2024 +0000 Bug 34355: (QA follow-up) Tidy Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer commit fc97c91493f7c25c5c2abc298ffebc9d1eeb1547 Author: Nick Clemens Date: Tue Nov 5 16:29:53 2024 +0000 Bug 34355: (QA follow-up) Remove debugging comment from archiving command Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer commit 3ee7c3ccbf6e0e1f955cd2bc2a989b0ceebcae3c Author: Matt Blenkinsop Date: Thu Oct 31 16:59:05 2024 +0000 Bug 34355: (QA follow-up) Respect AcqCreateItem syspref Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer commit 3bec59e965b9e36706b0c5b6aab16142864997a9 Author: Matt Blenkinsop Date: Thu Oct 31 14:50:39 2024 +0000 Bug 34355: (QA follow-up) Restore MarcFieldsToOrder prices and budgets Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer commit 738700b49a8d4d8bc089c90fc3a65e7e9b923774 Author: Matt Blenkinsop Date: Wed Oct 30 11:35:54 2024 +0000 Bug 34355: (QA follow-up) Permissions fixes This patch addresses some permissions errors and updates the breadcrumbs to reflect this Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer commit af22e7fad74dd1ec1d70a94dec51a651b3fdabed Author: Matt Blenkinsop Date: Mon Oct 21 14:18:36 2024 +0000 Bug 34355: (QA follow-up) Make record staging code DRY Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer commit 739300fde7a47965a55c38c3dae29035097d87c5 Author: Matt Blenkinsop Date: Mon Oct 21 13:13:05 2024 +0000 Bug 34355: (QA follow-up) Fix template errors This patch addresses the following issues: - Fixes a duplication of the SerialsDefaultReplyTo syspref - Re-introduces include files for overlay rules Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer commit 8c7418da957000f615c61b7cd72f05c5dab2c617 Author: Matt Blenkinsop Date: Mon Oct 21 12:51:34 2024 +0000 Bug 34355: (QA follow-up) Add a delete flag to the cronjob This patch adds a 'delete' flag to the cronjob to select whether a file should be deleted or archived once processed Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer commit 08eab5837f0a5802af0319773f21ff55df5b4b6c Author: Matt Blenkinsop Date: Mon Oct 21 09:52:03 2024 +0000 Bug 34355: (QA follow-up) Migrate vendor dropdown to a kohaSelect Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer